Conversation
- Upgrade dependencies to SilverStripe 6 compatible versions - dnadesign/silverstripe-elemental ^6.0 - silverstripe/linkfield ^5.0 - silvershop/silverstripe-hasonefield ^5.0 - unclecheese/display-logic ^4.0 - Add PHPStan static analysis with level 4 - Add PHPStan ignore comments for runtime-available methods - Update dev dependencies for testing and code quality
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the silverstripe-elemental-baseobject module to be compatible with SilverStripe 6, updating all major dependencies to their latest versions and introducing PHPStan static analysis at level 4.
- Updated core dependencies from SilverStripe 5 to 6 compatible versions
- Added PHPStan static analysis tooling with SilverStripe-specific rules
- Added PHPStan ignore comments for runtime-available methods that lack proper type definitions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| composer.json | Updated dependencies to SilverStripe 6 compatible versions and added PHPStan tooling |
| phpstan.neon | Added PHPStan configuration file with level 4 analysis |
| src/Model/BaseElementObject.php | Refactored method chaining and added PHPStan ignore comments for runtime methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
README.md
Outdated
| * SilverStripe ^6.0 | ||
| * dnadesign/silverstripe-elemental ^6.0 | ||
| * silverstripe/linkfield ^5.0 |
There was a problem hiding this comment.
[nitpick] The requirements list uses inconsistent formatting for version constraints. Line 14 uses ^6.0 while lines 15-16 omit the caret symbol. For consistency, either include ^ for all entries or use a consistent format throughout.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
composer.json
Outdated
| "silverstripe/frameworktest": "^1" | ||
| "cambis/silverstan": "^2.1", | ||
| "silverstripe/recipe-testing": "^4.0", | ||
| "squizlabs/php_codesniffer": "^3.7", |
There was a problem hiding this comment.
[nitpick] The squizlabs/php_codesniffer package appears to be newly added but is not mentioned in the PR description. If this is intentionally added for code quality checks, consider documenting it in the PR description alongside PHPStan. If it's already present in the codebase, this comment can be disregarded.
Overview
This PR adds SilverStripe 6 compatibility to the
silverstripe-elemental-baseobjectmodule.Changes
Dependency Updates
^5→^6.0^4.0→^5.0^4→^5.0^3→^4.0^3→^4.0Code Quality Improvements
cambis/silverstanfor SilverStripe-specific PHPStan rulesphpstan/extension-installerto automatically load PHPStan extensionssetFolderName()on UploadFieldsetRows()on TextareaFieldcanArchive()on versioned SiteTreeTesting
✅ All tests passing:
Compatibility